Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace List with Chain in Validated's docs #2472

Merged
merged 3 commits into from
Sep 25, 2018

Conversation

kun-song
Copy link
Contributor

@kun-song kun-song commented Sep 5, 2018

  • ValidatedNel to ValidatedNec
  • NonEmptyList to NonEmptyChain
  • List to Chain

@LukaJCB
Copy link
Member

LukaJCB commented Sep 6, 2018

This is great, thanks!
It still seems to run into some errors with tut though, it'd be great if you could fix those :)

@kun-song
Copy link
Contributor Author

kun-song commented Sep 6, 2018

Hi @LukaJCB , the reason for the tut errors is the missing toValidatedNec method of Validated, there's a toValidatedNel in it.

So should I add toValidatedNec to Validated, or what else I can do to avoid the errors?

Thanks :)

@LukaJCB
Copy link
Member

LukaJCB commented Sep 24, 2018

Can you merge this with master now that #2487 is merged? :)

@codecov-io
Copy link

codecov-io commented Sep 25, 2018

Codecov Report

Merging #2472 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2472   +/-   ##
=======================================
  Coverage   95.33%   95.33%           
=======================================
  Files         358      358           
  Lines        6533     6533           
  Branches      273      273           
=======================================
  Hits         6228     6228           
  Misses        305      305

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a6c91...a8b9ab9. Read the comment docs.

@kailuowang
Copy link
Contributor

Thank you!

@kailuowang kailuowang merged commit f335517 into typelevel:master Sep 25, 2018
@kun-song kun-song deleted the replace-list-with-chain branch September 25, 2018 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants