Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use as and void instead of map(_ => ) #2403

Merged
merged 1 commit into from
Aug 14, 2018
Merged

use as and void instead of map(_ => ) #2403

merged 1 commit into from
Aug 14, 2018

Conversation

julien-truffaut
Copy link
Contributor

No description provided.

Copy link
Contributor

@johnynek johnynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. One problem with all these specialized methods is that people often forget them and cause potential for deoptimizations.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@codecov-io
Copy link

codecov-io commented Aug 14, 2018

Codecov Report

Merging #2403 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2403   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         349      349           
  Lines        6000     6000           
  Branches      222      224    +2     
=======================================
  Hits         5701     5701           
  Misses        299      299
Impacted Files Coverage Δ
core/src/main/scala/cats/Functor.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/data/Kleisli.scala 97.08% <100%> (ø) ⬆️
core/src/main/scala/cats/FlatMap.scala 81.81% <100%> (ø) ⬆️
core/src/main/scala/cats/Reducible.scala 95.38% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578f140...851dca6. Read the comment docs.

@johnynek johnynek merged commit 30636cd into master Aug 14, 2018
@kailuowang kailuowang added this to the 1.3 milestone Aug 16, 2018
@larsrh larsrh deleted the use-as-void branch October 5, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants