Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monad[Free[Id, ?]] cannot be found #2383

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Monad[Free[Id, ?]] cannot be found #2383

merged 1 commit into from
Aug 13, 2018

Conversation

barambani
Copy link
Contributor

Issue #2281

@codecov-io
Copy link

codecov-io commented Aug 11, 2018 •
edited
Loading

Codecov Report

Merging #2383 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2383      +/-   ##
==========================================
+ Coverage   95.01%   95.01%   +<.01%     
==========================================
  Files         349      349              
  Lines        5998     6000       +2     
  Branches      222      221       -1     
==========================================
+ Hits         5699     5701       +2     
  Misses        299      299
Impacted Files Coverage Δ
free/src/main/scala/cats/free/Free.scala 92% <100%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9aa77a9...ac58eb7. Read the comment docs.

@kailuowang
Copy link
Contributor

Awesome, Thanks!

@kailuowang kailuowang merged commit f98b158 into typelevel:master Aug 13, 2018
@kailuowang kailuowang mentioned this pull request Aug 13, 2018
Closed
@barambani barambani deleted the issue-2281 branch August 13, 2018 16:00
@kailuowang kailuowang added this to the 1.3 milestone Aug 16, 2018
catostrophe pushed a commit to catostrophe/cats that referenced this pull request Sep 15, 2018
@barambani @catostrophe
Added Free instance for Id (typelevel#2383)
2e3a50e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaJCB LukaJCB LukaJCB approved these changes

@kailuowang kailuowang kailuowang approved these changes

@johnynek johnynek Awaiting requested review from johnynek

@ceedubs ceedubs Awaiting requested review from ceedubs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@barambani @codecov-io @kailuowang @LukaJCB