-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak a test to compile on latest Scala 2.13 nightlies #2359
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.2.x #2359 +/- ##
==========================================
+ Coverage 94.82% 95.01% +0.18%
==========================================
Files 349 349
Lines 6009 5993 -16
Branches 223 225 +2
==========================================
- Hits 5698 5694 -4
+ Misses 311 299 -12
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, did this fix the error?
yes |
Do we have any insight into why this wasn't required before but is now? I'll admit to never understanding what these |
@@ -59,6 +59,7 @@ class RepresentableSuite extends CatsSuite { | |||
} | |||
|
|||
{ | |||
implicit val isoPair = Isomorphisms.invariant[String => ?] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we name it isoFunction1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
@ceedubs I myself am not familiar with the issue either. I left this comment on the original issue with the little bits that I know of. Update: Just to summarize, this is one of those cases when scalac refuses to use an implicit def available in scope, rather insists that you should create a local implicit val and call that def explicitly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although we still don't know the root cause of this issue, but we never do, it's probably a scalac bug..
¯_(ツ)_/¯
|
Thanks @SethTisue! |
fixes #2355