Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak a test to compile on latest Scala 2.13 nightlies #2359

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

SethTisue
Copy link
Member

fixes #2355

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #2359 into 1.2.x will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            1.2.x    #2359      +/-   ##
==========================================
+ Coverage   94.82%   95.01%   +0.18%     
==========================================
  Files         349      349              
  Lines        6009     5993      -16     
  Branches      223      225       +2     
==========================================
- Hits         5698     5694       -4     
+ Misses        311      299      -12
Impacted Files Coverage Δ
core/src/main/scala/cats/arrow/Compose.scala 66.66% <0%> (-3.34%) ⬇️
...eycats-core/src/main/scala/alleycats/std/map.scala 4.76% <0%> (-1.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1875a...46a7fab. Read the comment docs.

Copy link
Member

@LukaJCB LukaJCB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, did this fix the error?

@SethTisue
Copy link
Member Author

did this fix the error?

yes

@LukaJCB LukaJCB requested a review from kailuowang August 3, 2018 14:20
@ceedubs
Copy link
Contributor

ceedubs commented Aug 3, 2018

Do we have any insight into why this wasn't required before but is now? I'll admit to never understanding what these Isomorphisms are used for in tests. This change should probably go in, but it makes me wary of whether there's a bigger potential issue.

@@ -59,6 +59,7 @@ class RepresentableSuite extends CatsSuite {
}

{
implicit val isoPair = Isomorphisms.invariant[String => ?]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can we name it isoFunction1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@kailuowang
Copy link
Contributor

kailuowang commented Aug 3, 2018

@ceedubs I myself am not familiar with the issue either. I left this comment on the original issue with the little bits that I know of.

Update: Just to summarize, this is one of those cases when scalac refuses to use an implicit def available in scope, rather insists that you should create a local implicit val and call that def explicitly.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although we still don't know the root cause of this issue, but we never do, it's probably a scalac bug..
¯_(ツ)_/¯

@ceedubs
Copy link
Contributor

ceedubs commented Aug 8, 2018

¯\_(ツ)_/¯

@ceedubs ceedubs merged commit 07b4625 into typelevel:1.2.x Aug 8, 2018
@ceedubs
Copy link
Contributor

ceedubs commented Aug 8, 2018

Thanks @SethTisue!

@kailuowang kailuowang added this to the 1.3 milestone Aug 16, 2018
@SethTisue SethTisue deleted the issue-2355 branch September 4, 2018 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants