Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one off object for importing lawless Map instances #2345

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

andyscott
Copy link
Contributor

Adds the ability to import just the lawless instances for Map.

Some context:
Right now the most sane way to import lawless map instances is via import alleycats.std.all._. However, this is problematic due to conflicting ambiguous instances between lawless Try and regular Try:

[error] SomeFile.scala:38: ambiguous implicit values:                                                                
[error]  both method catsStdInstancesForTry in trait TryInstances of type => cats.MonadError[scala.util.Try,Throwable] with cats.CoflatMap[scala.util.Try] with cats.Traverse[scala.util.Try] with cats.Monad[scala.util.Try]                                                                                             
[error]  and method legacyTryBimonad in trait LegacyTryInstances of type (implicit e: export.ExportOrphan[cats.Bimonad[scala.util.Try]])cats.Bimonad[scala.util.Try]                                             

@andyscott
Copy link
Contributor Author

At this rate I'll get approval from every maintainer before end of day!

Copy link
Member

@tpolecat tpolecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Approved!

@non
Copy link
Contributor

non commented Jul 27, 2018

👍

@codecov-io
Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #2345 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2345   +/-   ##
=======================================
  Coverage   95.09%   95.09%           
=======================================
  Files         345      345           
  Lines        5991     5991           
  Branches      217      219    +2     
=======================================
  Hits         5697     5697           
  Misses        294      294
Impacted Files Coverage Δ
...eycats-core/src/main/scala/alleycats/std/map.scala 4.76% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92c4b7a...92d1b32. Read the comment docs.

@kailuowang kailuowang merged commit 2ff0425 into typelevel:master Jul 27, 2018
@andyscott andyscott deleted the patch-6 branch July 27, 2018 18:55
@kailuowang kailuowang added this to the 1.3 milestone Aug 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants