Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 2.10 support / update to 2.13-M4 #2306

Merged
merged 4 commits into from
Jul 24, 2018
Merged

Drop 2.10 support / update to 2.13-M4 #2306

merged 4 commits into from
Jul 24, 2018

Conversation

larsrh
Copy link
Contributor

@larsrh larsrh commented Jun 24, 2018

There was some discussion in the cats-dev channel about dropping 2.10 support. The major reason is that it becomes increasingly cumbersome to support 2.10–2.13 in discipline.

I've browsed around the issue tracker here and didn't see any major discussion/consensus around 2.10 support, so I thought I'd give it a try and see what people say.

@codecov-io
Copy link

codecov-io commented Jun 24, 2018

Codecov Report

Merging #2306 into 1.2.x will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            1.2.x    #2306      +/-   ##
==========================================
+ Coverage   94.79%   95.09%   +0.29%     
==========================================
  Files         345      345              
  Lines        5979     5991      +12     
  Branches      216      219       +3     
==========================================
+ Hits         5668     5697      +29     
+ Misses        311      294      -17
Impacted Files Coverage Δ
laws/src/main/scala/cats/laws/MonadLaws.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/Ior.scala 98.48% <0%> (+0.01%) ⬆️
core/src/main/scala/cats/Eval.scala 98.83% <0%> (+0.04%) ⬆️
core/src/main/scala/cats/data/IorT.scala 97.79% <0%> (+0.04%) ⬆️
.../src/main/scala/cats/data/RepresentableStore.scala 87.5% <0%> (+4.16%) ⬆️
core/src/main/scala/cats/syntax/either.scala 99.16% <0%> (+14.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32a591...466bf81. Read the comment docs.

@rossabaker
Copy link
Member

I'd like to see a concrete example where 2.10 support causes friction, but once that appears, I'm in favor of dropping it. cats-effect already did, and that means a huge swath of the ecosystem followed.

@larsrh
Copy link
Contributor Author

larsrh commented Jun 25, 2018

@rossabaker typelevel/discipline#54: There's no uniform ScalaCheck version for 2.10–2.13. Scalatest and Specs2 differ in the supported ScalaCheck versions, too.

@travisbrown
Copy link
Contributor

I'm 👍 on dropping 2.10 support, but I think it's worth having someone with org.typelevel rights look at the Sonatype stats, if only to have an argument ready when people complain (circe-core downloads for example have been ~3% 2.10 for a while, and most of those are for non-current circe versions, anyway).

@larsrh
Copy link
Contributor Author

larsrh commented Jun 25, 2018

2.10

stats1

2.11

stats2

2.12

stats3

@kailuowang
Copy link
Contributor

Only 147 Cats_core_2.10 1.1.0 downloads vs 46K+ 2.11 and 2.12 downloads (3 months after the 1.1.0 release), I think it's safe to drop 2.10 support post 1.2.0. I vote that we let 1.2.0 be the last release supporting scala 2.10

@larsrh
Copy link
Contributor Author

larsrh commented Jun 25, 2018

Alright. I'm going to release a 2.11+ version of discipline then, which means that Cats has to wait until 1.2.0 1.3.0 for proper 2.13 support.

@kailuowang
Copy link
Contributor

Sounds good to me. Thanks @larsrh

@larsrh larsrh modified the milestones: 1.2, 1.3 Jun 25, 2018
@kailuowang kailuowang changed the base branch from master to 1.2.x July 23, 2018 20:55
@kailuowang kailuowang changed the title [WIP] drop 2.10 support Drop 2.10 support / update to 2.13-M4 Jul 23, 2018
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @larsrh! LGTM, but would you mind resolving the merge conflict in build.sbt?

@kailuowang
Copy link
Contributor

thanks @larsrh I merged the conflict. will merge it after build green.

@kailuowang kailuowang merged commit 16f9d81 into typelevel:1.2.x Jul 24, 2018
kailuowang added a commit that referenced this pull request Jul 26, 2018
* remove 2.13 for releases

* Setting version to 1.2.0

* Setting version to 1.2.1-SNAPSHOT

* post release update

* Use portable-scala crossProject (#2323)

* Use portable-scala crossProject

* Refine POM match for simulacrum

* Drop 2.10 support / update to 2.13-M4 (#2306)

* drop 2.10 support from the build

* drop Scala 2.10 /update to 2.13-M3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants