-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop 2.10 support / update to 2.13-M4 #2306
Conversation
Codecov Report
@@ Coverage Diff @@
## 1.2.x #2306 +/- ##
==========================================
+ Coverage 94.79% 95.09% +0.29%
==========================================
Files 345 345
Lines 5979 5991 +12
Branches 216 219 +3
==========================================
+ Hits 5668 5697 +29
+ Misses 311 294 -17
Continue to review full report at Codecov.
|
I'd like to see a concrete example where 2.10 support causes friction, but once that appears, I'm in favor of dropping it. cats-effect already did, and that means a huge swath of the ecosystem followed. |
@rossabaker typelevel/discipline#54: There's no uniform ScalaCheck version for 2.10–2.13. Scalatest and Specs2 differ in the supported ScalaCheck versions, too. |
I'm 👍 on dropping 2.10 support, but I think it's worth having someone with |
Only 147 Cats_core_2.10 1.1.0 downloads vs 46K+ 2.11 and 2.12 downloads (3 months after the 1.1.0 release), I think it's safe to drop 2.10 support post 1.2.0. I vote that we let 1.2.0 be the last release supporting scala 2.10 |
Alright. I'm going to release a 2.11+ version of discipline then, which means that Cats has to wait until |
Sounds good to me. Thanks @larsrh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @larsrh! LGTM, but would you mind resolving the merge conflict in build.sbt?
thanks @larsrh I merged the conflict. will merge it after build green. |
* remove 2.13 for releases * Setting version to 1.2.0 * Setting version to 1.2.1-SNAPSHOT * post release update * Use portable-scala crossProject (#2323) * Use portable-scala crossProject * Refine POM match for simulacrum * Drop 2.10 support / update to 2.13-M4 (#2306) * drop 2.10 support from the build * drop Scala 2.10 /update to 2.13-M3
There was some discussion in the cats-dev channel about dropping 2.10 support. The major reason is that it becomes increasingly cumbersome to support 2.10–2.13 in discipline.
I've browsed around the issue tracker here and didn't see any major discussion/consensus around 2.10 support, so I thought I'd give it a try and see what people say.