Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Law Testing" to side menu to increase visiblity. #2196

Merged
merged 1 commit into from
Mar 16, 2018

Conversation

wjlow
Copy link
Contributor

@wjlow wjlow commented Mar 16, 2018

Laws are important and the link to the Law Testing page is quite hidden (in a hyperlink all the way down the bottom of the Typeclasses page). I suspect making it more visible might encourage more people to learn how to test typeclass laws.

Here's a screenshot on how it would look:

law-testing-screen

Laws are important and the link to the Law Testing page is quite hidden (in a hyperlink all the way down the bottom of the Typeclasses page). I suspect making it more visible might encourage more people to learn how to test typeclass laws.
@codecov-io
Copy link

codecov-io commented Mar 16, 2018

Codecov Report

Merging #2196 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2196   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files         332      332           
  Lines        5697     5697           
  Branches      214      212    -2     
=======================================
  Hits         5400     5400           
  Misses        297      297

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 246b0e0...8fd21e9. Read the comment docs.

Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely 👍 One of the things I am frequently asked about.

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@LukaJCB LukaJCB merged commit 06041fb into typelevel:master Mar 16, 2018
@kailuowang kailuowang added this to the 1.1 milestone Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants