-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FreeT.inject helper function (#1534) #2169
Merged
Merged
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can
F[_]
be inferred too?Would the name
inject
be a bit confusing here? What aboutliftInject
orinjectLift
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, F[_] cannot be inferred as it's an implicit parameter of the
apply
method.This work is an adaption of the snippet in the Free file:
and similarly
F[_]
couldn't be inferred either.I agree that
liftInject
orinjectLift
are clearer, but I would argue to keep it like this for consistency. Don't mind change it though to one of the suggested name though 👍 .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can infer the type with a caveat.
I did have to explicitly pass the type
Test1(x, identity):Test1Algebra[Int])
, because scalac won't cast up fromTest1[_]
toTest1Algebra[_]
, however it wouldn't be problem if there is a helper method.Given that the helper method is useful in other situations ( like a simple
for
loop that only involvesTest1Algebra
) and a common pattern I still favor the version that I proposed.I actually propose we rename this one to
liftInject
and add anliftInject
toFree
that also infers onF[_]
as well. We can't deprecate the oldinject
but I guess we can comment it as "to be deprecated / removed in cats 2.0"There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedbacks / help. I've updated to PR accordingly 👍