Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a default id for Arrow #2072

Merged
merged 6 commits into from
Dec 6, 2017
Merged

added a default id for Arrow #2072

merged 6 commits into from
Dec 6, 2017

Conversation

kailuowang
Copy link
Contributor

we already have a law

    F.lift(identity[A]) <-> F.id[A]

so it's hard to see why this shouldn't be given as a default.

we already have a law 
```
    F.lift(identity[A]) <-> F.id[A]
```
so it's hard to see why this shouldn't be given as a default.
@kailuowang kailuowang added this to the 1.0.0 milestone Dec 6, 2017
LukaJCB
LukaJCB previously approved these changes Dec 6, 2017
ceedubs
ceedubs previously approved these changes Dec 6, 2017
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming build passes

@codecov-io
Copy link

codecov-io commented Dec 6, 2017

Codecov Report

Merging #2072 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2072      +/-   ##
==========================================
- Coverage   94.66%   94.66%   -0.01%     
==========================================
  Files         318      318              
  Lines        5383     5419      +36     
  Branches      207      208       +1     
==========================================
+ Hits         5096     5130      +34     
- Misses        287      289       +2
Impacted Files Coverage Δ
core/src/main/scala/cats/instances/function.scala 92.3% <ø> (ø) ⬆️
core/src/main/scala/cats/data/Cokleisli.scala 100% <ø> (ø) ⬆️
core/src/main/scala/cats/data/Kleisli.scala 97.7% <100%> (ø) ⬆️
core/src/main/scala/cats/arrow/Arrow.scala 100% <100%> (ø) ⬆️
core/src/main/scala/cats/Invariant.scala 94.36% <0%> (-0.88%) ⬇️
core/src/main/scala/cats/Alternative.scala 93.75% <0%> (+4.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec13814...3ff449f. Read the comment docs.

@kailuowang kailuowang merged commit 492fe75 into master Dec 6, 2017
@kailuowang kailuowang deleted the default_id_for_arrow branch December 6, 2017 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants