Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scalafix testing instructions #2045

Merged
merged 2 commits into from
Nov 29, 2017
Merged

Fix scalafix testing instructions #2045

merged 2 commits into from
Nov 29, 2017

Conversation

kubukoz
Copy link
Member

@kubukoz kubukoz commented Nov 25, 2017

No description provided.

@ChristopherDavenport
Copy link
Member

I've always used sbt "; ...;..." when running multiple commands. I'm surprised that either of the above work well.

@kubukoz
Copy link
Member Author

kubukoz commented Nov 25, 2017

Well, it doesn't work on Mac as it is in the repo. I'm still figuring out the correct way, though ;)

@kubukoz
Copy link
Member Author

kubukoz commented Nov 25, 2017

In fact, I don't see the project coreFree at all...

@kubukoz
Copy link
Member Author

kubukoz commented Nov 25, 2017

sbt coreJVM/publishLocal freeJVM/publishLocal should do the job if I'm not mistaken in thinking that freeJVM is the correct replacement for coreFree. I'll update the PR once it's confirmed.
(cd scalafix; sbt test works with that, so I assume it's correct)

@kubukoz
Copy link
Member Author

kubukoz commented Nov 25, 2017

Ahh, we need macrosJVM/publishLocal and kernelJVM/publishLocal as well

@kubukoz
Copy link
Member Author

kubukoz commented Nov 25, 2017

With all these subprojects we need to publish, maybe there's a way to just publish all things JVM? :)

@codecov-io
Copy link

codecov-io commented Nov 25, 2017

Codecov Report

Merging #2045 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2045      +/-   ##
==========================================
+ Coverage      95%   95.05%   +0.04%     
==========================================
  Files         311      311              
  Lines        5266     5257       -9     
  Branches      131      123       -8     
==========================================
- Hits         5003     4997       -6     
+ Misses        263      260       -3
Impacted Files Coverage Δ
core/src/main/scala/cats/syntax/flatMap.scala 66.66% <0%> (-13.34%) ⬇️
core/src/main/scala/cats/instances/sortedMap.scala 95.23% <0%> (-0.08%) ⬇️
core/src/main/scala/cats/data/EitherT.scala 97.58% <0%> (-0.02%) ⬇️
core/src/main/scala/cats/FlatMap.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/OptionT.scala 100% <0%> (ø) ⬆️
core/src/main/scala/cats/data/WriterT.scala 94.68% <0%> (+0.93%) ⬆️
...in/scala/cats/data/IndexedReaderWriterStateT.scala 100% <0%> (+0.93%) ⬆️
core/src/main/scala/cats/data/Kleisli.scala 98.76% <0%> (+1.17%) ⬆️
core/src/main/scala/cats/data/IndexedStateT.scala 100% <0%> (+1.19%) ⬆️
core/src/main/scala/cats/Applicative.scala 83.33% <0%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f403ef...2158de3. Read the comment docs.

@kailuowang
Copy link
Contributor

On Travis it runs

sbt ;coreJVM/publishLocal;freeJVM/publishLocal
cd scalafix
sbt tests/test
cd ..

@kubukoz
Copy link
Member Author

kubukoz commented Nov 29, 2017

Sorry, I didn't see your comment before.

Well, running sbt ;coreJVM/publishLocal;freeJVM/publishLocal doesn't seem to work with either zsh or bash on Mac (iterm2 / terminal are both affected). It just opens the sbt shell...

It seems right that for tests/test we only need coreJVM and freeJVM, so this should be portable enough, and I suggest to change the readme to:
sbt coreJVM/publishLocal freeJVM/publishLocal

the other modules were needed for the whole test task (and most likely for correct depedency resolution in IDEA). We might want to mention that in the readme too...

@kailuowang
Copy link
Contributor

thanks very much! since this is very straightforward documentation correction, I am going to merge with 1 sign-off

@kailuowang kailuowang merged commit 80dd4d1 into typelevel:master Nov 29, 2017
@kailuowang kailuowang added this to the 1.0.0 milestone Nov 29, 2017
@kubukoz kubukoz deleted the patch-1 branch November 29, 2017 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants