rename Cartesian to Semigroupal #1961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1961 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 273 273
Lines 4538 4538
Branches 119 122 +3
=======================================
Hits 4360 4360
Misses 178 178
Continue to review full report at Codecov.
|
LukaJCB
previously approved these changes
Oct 10, 2017
edmundnoble
previously approved these changes
Oct 11, 2017
| "invariant cartesian associativity" -> forAll((fa: F[A], fb: F[B], fc: F[C]) => laws.invariantMonoidalAssociativity(fa, fb, fc)) | ||
| "invariant semigroupal left identity" -> forAll((fa: F[A], b: B) => laws.invariantMonoidalLeftIdentity(fa, b)), | ||
| "invariant semigroupal right identity" -> forAll((fa: F[A], b: B) => laws.invariantMonoidalRightIdentity(fa, b)), | ||
| "invariant semigroupal associativity" -> forAll((fa: F[A], fb: F[B], fc: F[C]) => laws.invariantMonoidalAssociativity(fa, fb, fc)) |
There was a problem hiding this comment.
"Invariant monoidal left identity"?
| ## To test scala fix | ||
|
|
||
| ```bash | ||
| sbt ;coreJVM/publishLocal;coreFree/publishLocal |
There was a problem hiding this comment.
Is this redundant with the other scalafix PR?
There was a problem hiding this comment.
Are you referring the PR that add this to travis? This is to add it to readme so people know how to run the test locally.
| object RenameCartesianTests { | ||
| import cats.syntax.semigroupal._ | ||
|
|
||
| def prod[F[_]: Semigroupal, A, B](fa: F[A], fb: F[B]): F[(A, B)] = Semigroupal[F].product(fa, fb) |
| } | ||
|
|
||
| // ref: https://github.com/typelevel/cats/pull/1961 |
LukaJCB
previously approved these changes
Oct 11, 2017
LukaJCB
previously approved these changes
Oct 11, 2017
LukaJCB
reviewed
Oct 11, 2017
| @@ -90,4 +90,7 @@ package object cats { | |||
| val Semigroup = cats.kernel.Semigroup | |||
| val Monoid = cats.kernel.Monoid | |||
| val Group = cats.kernel.Group | |||
|
|
|||
| @deprecated("renamed to Semigroupal", "1.0.0-RC1") | |||
| type Cartesian[F[_]] = Semigroupal[F] | |||
There was a problem hiding this comment.
I think you've got some extra white space here
LukaJCB
approved these changes
Oct 11, 2017
|
I'm going to go ahead and merge this. It got 2 sign-offs (1 of which dismissed by minor changes ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1931 with a deprecated type alias and scalafix
There are two commits in this PR the de6345e is the mechanical rename one - not much to look here.
the f42419b adds a scalafix rule that should be easy to review separately