Added examples of Arrow composition #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for the contribution! :) You have some style errors, you should fix before we can merge though. You can check them by running |
|
Thanks |
|
Thanks for alerting me to that @LukaJCB |
lorenasmith2017
approved these changes
Oct 8, 2017
kailuowang
reviewed
Oct 9, 2017
| * scala> import cats.implicits._ | ||
| * scala> import cats.arrow._ | ||
| * scala> val f = (_ + 1) | ||
| * scala> val g = (_ * 100) |
There was a problem hiding this comment.
the above two lines don't compile
/home/travis/build/typelevel/cats/core/.jvm/target/scala-2.10/src_managed/test/cats/arrow/ComposeDoctest.scala:20: missing parameter type for expanded function
|
apologize for missing that out.
…On Mon, Oct 9, 2017 at 10:50 PM, Kai(luo) Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In core/src/main/scala/cats/arrow/Compose.scala
<#1952 (comment)>:
> @@ -8,6 +8,20 @@ import simulacrum.typeclass
*/
@typeclass trait Compose[F[_, _]] { self =>
+ /**
+ * Here's how you can use `>>>` and `<<<`
+ * Example:
+ * {{{
+ * scala> import cats.implicits._
+ * scala> import cats.arrow._
+ * scala> val f = (_ + 1)
+ * scala> val g = (_ * 100)
the above two lines don't compile
/home/travis/build/typelevel/cats/core/.jvm/target/scala-2.
10/src_managed/test/cats/arrow/ComposeDoctest.scala:20: missing parameter
type for expanded function
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1952 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAbUwDvV91vJPa3wbo-4_uYw3Dw7mayvks5sqjK_gaJpZM4PxOoX>
.
|
|
Not at all, @raymondtay thank you very much for contributing to Cats! |
|
I really enjoyed this library !
…On Mon, Oct 9, 2017 at 11:01 PM, Kai(luo) Wang ***@***.***> wrote:
Not at all, @raymondtay <https://github.com/raymondtay> thank you very
much for contributing to Cats!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1952 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAbUwAfKwTVawXgJPkw2143-aD6ZrS5hks5sqjVWgaJpZM4PxOoX>
.
|
Codecov Report
@@ Coverage Diff @@
## master #1952 +/- ##
=======================================
Coverage 96.14% 96.14%
=======================================
Files 273 273
Lines 4535 4535
Branches 114 114
=======================================
Hits 4360 4360
Misses 175 175
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Oct 10, 2017
LukaJCB
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought it might be useful for readers to understand Arrow composition at first glance.