Consolidate readme.md and index.md #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov Report
@@ Coverage Diff @@
## master #1915 +/- ##
=======================================
Coverage 95.54% 95.54%
=======================================
Files 248 248
Lines 4420 4420
Branches 121 124 +3
=======================================
Hits 4223 4223
Misses 197 197Continue to review full report at Codecov.
|
LukaJCB
approved these changes
Sep 19, 2017
ceedubs
approved these changes
Sep 20, 2017
|
since this is a documentation only and straightforward change I am going to merge with one maintainer sign-off and one contributor sign-off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1896
Right the two documents are highly duplicated. Using a sbt-microsite setting, we can use the same document both as the github readme and the index of the site.
After the consolidation, the readme file was a bit too long, so I extract the motivations section to a separate page.