s/rewrites/rules and update scalafix version in the README #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1905 +/- ##
======================================
Coverage 95.2% 95.2%
======================================
Files 248 248
Lines 4379 4379
Branches 118 118
======================================
Hits 4169 4169
Misses 210 210Continue to review full report at Codecov.
|
|
🤔 mm tests don't seem to pass anymore, I'm investigating... |
|
ok, everything works correctly now. I also took the opportunity to use the new |
- ctx.replaceSymbols also renames - ctx.replaceSymbols also removes imports - Tree.is[Comma] instead of `.syntax == ","` - Tree.collectFirst/exists from contrib module. - tokenList.leading().takeWhile to strip leading whitespace
Refactor scalafix migration rewrite
kailuowang
approved these changes
Sep 11, 2017
ceedubs
approved these changes
Sep 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a follow up of #1902, in which I forgot to:
rewritestorules(this made the github shorthand syntax fail)Sorry for the double PR!