Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalastyle-sbt-plugin to 1.0.0 #1839

Merged
merged 2 commits into from
Aug 30, 2017

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Aug 21, 2017

This version is compatible with sbt 1.0.0 and allows to get rid of
a workaround for scalastyle/scalastyle-sbt-plugin#47.

It also complained about new issues which I've ignored for now. The same
issues already have been silenced in other places of the library.

This version is compatible with sbt 1.0.0 and allows to get rid of
a workaround for scalastyle/scalastyle-sbt-plugin#47.

It also complained about new issues which I've ignored for now. The same
issues already have been silenced in other places of the library.
@codecov-io
Copy link

codecov-io commented Aug 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@2305ca6). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1839   +/-   ##
=========================================
  Coverage          ?   94.96%           
=========================================
  Files             ?      241           
  Lines             ?     4193           
  Branches          ?      109           
=========================================
  Hits              ?     3982           
  Misses            ?      211           
  Partials          ?        0
Impacted Files Coverage Δ
...ws/src/main/scala/cats/kernel/laws/OrderLaws.scala 100% <ø> (ø)
.../src/main/scala/cats/kernel/instances/bitSet.scala 100% <ø> (ø)
kernel/src/main/scala/cats/kernel/Comparison.scala 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2305ca6...9806e80. Read the comment docs.

@kailuowang kailuowang added this to the 1.0.0-RC1 milestone Aug 29, 2017
@non
Copy link
Contributor

non commented Aug 30, 2017

LGTM 👍

@non non merged commit 19be2cd into typelevel:master Aug 30, 2017
@non non removed the in progress label Aug 30, 2017
@fthomas fthomas deleted the scalastyle-sbt-plugin-1.0.0 branch August 30, 2017 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants