Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrease stack-safety test size #1760

Merged

Conversation

edmundnoble
Copy link
Contributor

Locally looping 60000-deep in a recursive function is enough to blow my stack; as it is, these tests still fail on my machine with Eval swapped for Id.

@codecov-io
Copy link

codecov-io commented Jul 7, 2017

Codecov Report

Merging #1760 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1760   +/-   ##
=======================================
  Coverage   94.17%   94.17%           
=======================================
  Files         256      256           
  Lines        4208     4208           
  Branches       93       93           
=======================================
  Hits         3963     3963           
  Misses        245      245

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 099e459...dc29715. Read the comment docs.

@edmundnoble
Copy link
Contributor Author

edmundnoble commented Jul 7, 2017

Notably decreases test duration on CI:
before @peterneyens' PR
@peterneyens' PR
this PR

I don't know if/how translates to a lower average total test time.

@peterneyens peterneyens merged commit 8e8c654 into typelevel:master Jul 7, 2017
@kailuowang kailuowang added this to the 1.0.0-MF milestone Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants