Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StateT no longer violates laws #1735

Merged
merged 3 commits into from
Jun 20, 2017
Merged

StateT no longer violates laws #1735

merged 3 commits into from
Jun 20, 2017

Commits on Jun 1, 2017

  1. Improve StateT Arbitrary instance 

    As pointed out [here](typelevel#1640 (comment))

This reveals law violations in `StateT`. It looks like `flatMap`/`ap`
consistency does not hold, as well as `MonadCombine`
right-distributivity. It's not immediately clear to me how to fix this,
so I'm opening this up in case somebody else gets to it first.
    @ceedubs
    ceedubs committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    06011a1 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2017

  1. Removed unsound overrides of StateT applicative machinery

    @djspiewak
    djspiewak committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    74a3404 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into statet-arb

    @djspiewak
    djspiewak committed Jun 20, 2017
    Configuration menu
    Copy the full SHA
    2868cba View commit details
    Browse the repository at this point in the history