Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added two links to the learner page #1697

Merged
merged 4 commits into from
Jun 1, 2017
Merged

Added two links to the learner page #1697

merged 4 commits into from
Jun 1, 2017

Conversation

kailuowang
Copy link
Contributor

No description provided.

@kailuowang
Copy link
Contributor Author

kailuowang commented May 24, 2017

Already checked with @mpilquist. @BartoszMilewski please feel free to let us know if you have issues with us linking to your online lectures, thanks!

@codecov-io
Copy link

codecov-io commented May 24, 2017

Codecov Report

Merging #1697 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
- Coverage   93.93%   93.92%   -0.02%     
==========================================
  Files         241      246       +5     
  Lines        4091     4260     +169     
  Branches      151      155       +4     
==========================================
+ Hits         3843     4001     +158     
- Misses        248      259      +11
Impacted Files Coverage Δ
free/src/main/scala/cats/free/FreeT.scala 92.52% <0%> (-1.07%) ⬇️
core/src/main/scala/cats/data/NonEmptyList.scala 97.2% <0%> (-0.05%) ⬇️
free/src/main/scala/cats/free/Trampoline.scala 0% <0%> (ø) ⬆️
core/src/main/scala/cats/data/NonEmptyVector.scala 100% <0%> (ø) ⬆️
...main/scala/cats/laws/discipline/FlatMapTests.scala 100% <0%> (ø) ⬆️
...e/src/main/scala/cats/instances/partialOrder.scala 100% <0%> (ø)
core/src/main/scala/cats/instances/semigroup.scala 75% <0%> (ø)
core/src/main/scala/cats/instances/order.scala 100% <0%> (ø)
core/src/main/scala/cats/instances/eq.scala 100% <0%> (ø)
core/src/main/scala/cats/instances/monoid.scala 88.88% <0%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 829296e...4be955f. Read the comment docs.

of lectures about basic functional structures.
* [Category Theory for Programmers](https://www.youtube.com/playlist?list=PLbgaMIhjbmEnaH_LTkxLI7FMa2HsnawM_)
by [Bartosz Milewski](https://github.com/BartoszMilewski) is a wonder
serias of category theory lectures oriented towards programmers. The
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

serias -> series

  by [Michael Pilquist](https://github.com/MPilquist) offers a series
of lectures about basic functional structures.
* [Category Theory for Programmers](https://www.youtube.com/playlist?list=PLbgaMIhjbmEnaH_LTkxLI7FMa2HsnawM_)
by [Bartosz Milewski](https://github.com/BartoszMilewski) is a wonder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, 2 kind of nitpicky questions/comments.

What exactly do you mean by "wonder series"? Did you mean "wonderful series"? If so, "wonderful" is probably fine, but it might be better to use a more objective description.

I'm a bit hesitant to say "should be easy for non-Haskell programmers to follow". Even introductory category theory and haskell can be a big paradigm shift for people, and I don't want to discourage people or have them feel bad about themselves if they don't easily follow it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are really good points. Thanks @ceedubs!

Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes @kailuowang. This looks great to me.

@kailuowang kailuowang merged commit 1931c93 into master Jun 1, 2017
@kailuowang kailuowang deleted the update-learner-page branch June 1, 2017 13:41
@kailuowang kailuowang added this to the 1.0.0-MF milestone Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants