Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make InjectK use FunctionK.id for reflexive injection #1641

Merged

Conversation

andyscott
Copy link
Contributor

Tiny tweak.

A similar update/cleanup can be done if an applicative for type constructors is introduced and a "liftK" helper is added to FunctionK

Copy link
Contributor

@kailuowang kailuowang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andyscott andyscott force-pushed the misc/injectk-use-functionk-id branch from 38d3b8e to 6989445 Compare April 30, 2017 17:58
@codecov-io
Copy link

codecov-io commented Apr 30, 2017

Codecov Report

Merging #1641 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1641   +/-   ##
=======================================
  Coverage   93.37%   93.37%           
=======================================
  Files         240      240           
  Lines        3941     3941           
  Branches      144      138    -6     
=======================================
  Hits         3680     3680           
  Misses        261      261
Impacted Files Coverage Δ
core/src/main/scala/cats/InjectK.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f686984...6989445. Read the comment docs.

@peterneyens peterneyens merged commit 5a90b61 into typelevel:master Apr 30, 2017
@kailuowang kailuowang modified the milestone: 1.0.0-MF May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants