show(f:T) to show(t:T) #1637
Merged
show(f:T) to show(t:T) #1637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f could be misleading. usually f parameter is used for functions
Codecov Report
@@ Coverage Diff @@
## master #1637 +/- ##
=======================================
Coverage 93.37% 93.37%
=======================================
Files 240 240
Lines 3937 3937
Branches 139 138 -1
=======================================
Hits 3676 3676
Misses 261 261
Continue to review full report at Codecov.
|
|
merged with one sign-off since this is a simple typo correction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
f could be misleading. usually f parameter is used for functions