add optional to Applicative #1560
Conversation
|
Edit: duh, I didn't see the I am curious can this in be in |
| @@ -37,6 +37,10 @@ import simulacrum.typeclass | |||
| def sequence[G[_], A](as: G[F[A]])(implicit G: Traverse[G]): F[G[A]] = | |||
| G.sequence(as)(this) | |||
|
|
|||
| /** one or none */ | |||
There was a problem hiding this comment.
I think we need more comments than this. For F = List this will be one and none (we will always concatenate None to the list), so it behavior seems highly dependant on the F.
There was a problem hiding this comment.
What is the intended usecase of this method?
Codecov Report
@@ Coverage Diff @@
## master #1560 +/- ##
==========================================
+ Coverage 92.49% 92.49% +<.01%
==========================================
Files 246 246
Lines 3891 3892 +1
Branches 136 135 -1
==========================================
+ Hits 3599 3600 +1
Misses 292 292
Continue to review full report at Codecov.
|
|
@kailuowang we need @johnynek I thought about the same just after submitting the PR, as you say the behaviour depends mainly on |
|
@julien-truffaut do you need this for the next release? |
|
No I am fine without. Thanks
On Thu, 13 Jul 2017 at 16:36, Kai(luo) Wang ***@***.***> wrote:
@julien-truffaut <https://github.com/julien-truffaut> do you need this
for the next release?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1560 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABxfWXbXBLfbSws-yYPJhKfl811D6e6Pks5sNiuDgaJpZM4MeKds>
.
--
Julien Truffaut
Tel : +44 7743 449664
|
|
Closing stale PRs. Feel free to reopen if there is interest to revive the effort. |
|
just a note, isn't Applicative + SemigroupK == Alternative? shouldn't this be on alternative? |
|
@johnynek Applicative + MonoidK == Alternative, not SemigroupK alone |
No description provided.