add to Monad ifM example #1546
add to Monad ifM example #1546
Conversation
| @@ -112,6 +112,8 @@ statement into the monadic context. | |||
| import cats.implicits._ | |||
|
|
|||
| Monad[List].ifM(List(true, false, true))(List(1, 2), List(3, 4)) | |||
|
|
|||
| Monad[List].ifM(List(true, false, false))(List(1, 2), List(3, 4)) | |||
There was a problem hiding this comment.
how about also adding names to parameters?
like
Monad[List].ifM(List(true, false, true))(ifTrue = List(1, 2), ifFalse = List(3, 4))
There was a problem hiding this comment.
If we did that I think we could leave out the extra example. I will add parameter names. Do you want me to pull the second example?
sullivan-
force-pushed
the
docs-monad-ifm
branch
from
6b18fde
to
d8b28fa
Compare
|
I added param names, left the second example in. happy to adjust further. I did a |
Codecov Report
@@ Coverage Diff @@
## master #1546 +/- ##
=======================================
Coverage 92.48% 92.48%
=======================================
Files 246 246
Lines 3885 3885
Branches 132 132
=======================================
Hits 3593 3593
Misses 292 292Continue to review full report at Codecov.
|
| Monad[List].ifM(List(true, false, true))(List(1, 2), List(3, 4)) | ||
| Monad[List].ifM(List(true, false, true))(ifTrue = List(1, 2), ifFalse = List(3, 4)) | ||
|
|
||
| Monad[List].ifM(List(true, false, false))(ifTrue = List(1, 2), ifFalse = List(3, 4)) |
There was a problem hiding this comment.
I agree that with the parameter names, the second example looks redundant.
There was a problem hiding this comment.
tend to agree, parameter names make it clear imo
i also was confused by the original example
There was a problem hiding this comment.
thanks, i got rid of the extra line
I found this section pretty confusing, but cleared up my misunderstanding quickly in the console. added param names per suggestions on PR.
sullivan-
force-pushed
the
docs-monad-ifm
branch
from
d8b28fa
to
06cac41
Compare
|
👍 |
I found this section pretty confusing, but cleared up my misunderstanding quickly in the console.
This extra line in the example might help make it clear to people what is going on.