Add FlatMap.forEffect #1537
Merged
Add FlatMap.forEffect #1537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1537 +/- ##
==========================================
+ Coverage 92.42% 93.04% +0.61%
==========================================
Files 249 249
Lines 3974 3980 +6
Branches 131 139 +8
==========================================
+ Hits 3673 3703 +30
+ Misses 301 277 -24
Continue to review full report at Codecov.
|
kailuowang
approved these changes
Apr 11, 2017
kailuowang
reviewed
Apr 11, 2017
| def forEffect[A, B](fa: F[A])(fb: F[B]): F[A] = flatMap(fa)(a => map(fb)(_ => a)) | ||
|
|
||
| /** Alias for [[forEffect]]. */ | ||
| @inline final def <<[A, B](fa: F[A])(fb: F[B]): F[A] = forEffect(fa)(fb) |
There was a problem hiding this comment.
This line is the only missed test coverage, I think it's fine.
kailuowang
approved these changes
Apr 11, 2017
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1535.