Implement NonEmptyVector#filterNot #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.39% (diff: 100%)@@ master #1514 diff @@
==========================================
Files 246 246
Lines 3731 3732 +1
Methods 3609 3610 +1
Messages 0 0
Branches 122 122
==========================================
+ Hits 3447 3448 +1
Misses 284 284
Partials 0 0
|
|
👍 LGTM. Thanks! |
|
👍 Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up for the PR #1512,
NonEmptyVectoris also implementing the filter method, but not thefilterNot, which is available atscala.collection.immutable.Vector. This method is useful in order to avoid negating a filter condition.