-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functor tupleLeft and tupleRight #1468
Conversation
Current coverage is 92.23% (diff: 100%)@@ master #1468 diff @@
==========================================
Files 242 242
Lines 3619 3621 +2
Methods 3549 3553 +4
Messages 0 0
Branches 70 68 -2
==========================================
+ Hits 3338 3340 +2
Misses 281 281
Partials 0 0
|
👍 |
I have been thinking about adding these myself, but I wonder if we can't come up with some easier names (even though that's what they are called in scalaz and there seems to be a If nobody shares my concern, I am fine adding these as they stand. |
@peterneyens I am inclined to agree, but I don't at all feel strongly. |
.tuple for F[A], B to F[(A, B)] and .tupleSwap for the the other variant
|
Since we have |
Add tests tupleRight/tupleLeft
277923a
to
6068406
Compare
I've switched it around to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
👍 |
strengthL
andstrengthR
forFunctor
s. Tuple regular values with effectful ones.