Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use friendly name in POM for published artifacts - fixes #1396 #1426

Merged
merged 1 commit into from
Oct 25, 2016
Merged

Use friendly name in POM for published artifacts - fixes #1396 #1426

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ lazy val catsJS = project.in(file(".catsJS"))


lazy val macros = crossProject.crossType(CrossType.Pure)
.settings(moduleName := "cats-macros")
.settings(moduleName := "cats-macros", name := "Cats macros")
.settings(catsSettings:_*)
.jsSettings(commonJsSettings:_*)
.jvmSettings(commonJvmSettings:_*)
Expand All @@ -213,7 +213,7 @@ lazy val macrosJS = macros.js

lazy val kernel = crossProject.crossType(CrossType.Pure)
.in(file("kernel"))
.settings(moduleName := "cats-kernel")
.settings(moduleName := "cats-kernel", name := "Cats kernel")
.settings(kernelSettings: _*)
.settings(buildSettings: _*)
.settings(publishSettings: _*)
Expand All @@ -228,7 +228,7 @@ lazy val kernelJS = kernel.js

lazy val kernelLaws = crossProject.crossType(CrossType.Pure)
.in(file("kernel-laws"))
.settings(moduleName := "cats-kernel-laws")
.settings(moduleName := "cats-kernel-laws", name := "Cats kernel laws")
.settings(kernelSettings: _*)
.settings(buildSettings: _*)
.settings(publishSettings: _*)
Expand All @@ -245,7 +245,7 @@ lazy val kernelLawsJS = kernelLaws.js

lazy val core = crossProject.crossType(CrossType.Pure)
.dependsOn(macros, kernel)
.settings(moduleName := "cats-core")
.settings(moduleName := "cats-core", name := "Cats core")
.settings(catsSettings:_*)
.settings(sourceGenerators in Compile += (sourceManaged in Compile).map(Boilerplate.gen).taskValue)
.settings(includeGeneratedSrc)
Expand All @@ -260,7 +260,7 @@ lazy val coreJS = core.js

lazy val laws = crossProject.crossType(CrossType.Pure)
.dependsOn(macros, kernel, core, kernelLaws)
.settings(moduleName := "cats-laws")
.settings(moduleName := "cats-laws", name := "Cats laws")
.settings(catsSettings:_*)
.settings(disciplineDependencies:_*)
.configureCross(disableScoverage210Jvm)
Expand All @@ -274,7 +274,7 @@ lazy val lawsJS = laws.js

lazy val free = crossProject.crossType(CrossType.Pure)
.dependsOn(macros, core, tests % "test-internal -> test")
.settings(moduleName := "cats-free")
.settings(moduleName := "cats-free", name := "Cats Free")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason "Free" is capitalized here (unlike the others)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did it because it was named after the Free monad which I usually see capitalized. I can make it lower case if folks prefer that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. I don't have a strong opinion either way (but would prefer lowercase).

.settings(catsSettings:_*)
.jsSettings(commonJsSettings:_*)
.jvmSettings(commonJvmSettings:_*)
Expand Down