Topic/kernel big decimal #1319
Merged
Topic/kernel big decimal #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 LGTM, we, with another project, had some problem with BigDecimal precision handling in scala 2.10, but I think in this context, having an |
Current coverage is 91.54% (diff: 100%)@@ master #1319 diff @@
==========================================
Files 233 234 +1
Lines 3496 3572 +76
Methods 3442 3513 +71
Messages 0 0
Branches 54 59 +5
==========================================
+ Hits 3168 3270 +102
+ Misses 328 302 -26
Partials 0 0
|
|
can you update this to https://github.com/typelevel/cats/blob/master/build.sbt#L210 |
|
👍 |
|
I'm going to merge with two sign-offs. Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add order and commutative group instances for
BigDecimal.This fixes #1295.