Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add johnynek as a maintainer #1180

Merged
merged 1 commit into from
Jul 11, 2016
Merged

Add johnynek as a maintainer #1180

merged 1 commit into from
Jul 11, 2016

Conversation

ceedubs
Copy link
Contributor

@ceedubs ceedubs commented Jul 8, 2016

@johnynek's Cats contributions started fairly recently, but @johnynek was a big part of the algebra effort that led to cats-kernel and has contributed some nice changes and feedback since the creation of cats-kernel. Like @non, @johnynek is a person who is performance-conscious, and I think that Cats could benefit from this area of knowledge/awareness.

@johnynek thanks for the great work. Add a 👍 if you would like to be added as a maintainer.

If anyone has reason to believe that this candidate's conduct does not align with typelevel's code of conduct or goal of an inclusive, welcoming and safe environment; please contact a typelevel member (contact information is provided at the bottom of the code of conduct) via email or private Gitter message.

@johnynek's Cats contributions started fairly recently, but @johnynek was a big part of the algebra effort that led to cats-kernel and has contributed some nice changes and feedback since the creation of cats-kernel. Like @non, @johnynek is a person who is performance-conscious, and I think that Cats could benefit from this area of knowledge/awareness.
@kailuowang
Copy link
Contributor

👍

@codecov-io
Copy link

Current coverage is 88.79%

Merging #1180 into master will not change coverage

@@             master      #1180   diff @@
==========================================
  Files           233        233          
  Lines          3079       3079          
  Methods        3025       3025          
  Messages          0          0          
  Branches         51         51          
==========================================
  Hits           2734       2734          
  Misses          345        345          
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 341b188...9e6dc1e

@johnynek
Copy link
Contributor

johnynek commented Jul 8, 2016

I feel honored and welcomed! Looking forward to helping with cats!

👍

@milessabin
Copy link
Member

Regardless of what codecov.io says, I'm sure that merging this PR will improve coverage.

@ceedubs ceedubs merged commit e54a9be into master Jul 11, 2016
@ceedubs ceedubs deleted the maintainers-johnynek branch July 11, 2016 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants