Adding lift and inspect to StateT #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 88.81%@@ master #1169 diff @@
==========================================
Files 232 233 +1
Lines 3073 3084 +11
Methods 3021 3033 +12
Messages 0 0
Branches 49 48 -1
==========================================
+ Hits 2729 2739 +10
- Misses 344 345 +1
Partials 0 0
|
zainab-ali
changed the title
| StateT(s => F.map(fa)(a => (s, a))) | ||
|
|
||
| def inspect[F[_], S, A](f: S => F[A])(implicit F: Applicative[F]): StateT[F, S, A] = | ||
| StateT(s => F.map(f(s))(a => (s, a))) |
There was a problem hiding this comment.
Should we have inspect take S => A and create a separate inspectF for S => F[A]? It seems like the simple S => A case might be pretty common, so it might be nice to make it concise.
There was a problem hiding this comment.
Agreed. I'm thinking of adding a modify taking S => S and a modifyF taking S => F[S] while
I'm at it.
|
👍 looks great to me. Thanks @zainab-ali! |
|
👍 many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding utility functions
liftandinspectto theStateTobject.