Fix Scalastyle

[peterneyens]

Like @fthomas mentioned in #1092, we needed to update our scalastyle configuration because of scalastyle/scalastyle-sbt-plugin#47.

I used the same workaround as circe (circe/circe#156) and refined (fthomas/refined#122).

I am not sure if commonSettings is the right place in build.sbt to add it ?

[codecov-io]

Current coverage is 88.89%

Merging #1093 into master will not change coverage

@@             master      #1093   diff @@
==========================================
  Files           226        226          
  Lines          2916       2916          
  Methods        2865       2865          
  Messages          0          0          
  Branches         48         48          
==========================================
  Hits           2592       2592          
  Misses          324        324          
  Partials          0          0          

Powered by Codecov. Last updated by 00839fb...77f3de3

[ceedubs]

I might be reading or understanding this incorrectly, but it looks like the scalastyle:off has return, but scalastyle:on has magic.number. Is this a mistake?

[peterneyens]

That's a mistake indeed, thanks for spotting it !

[ceedubs]

Thanks! I left one minor question, but 👍 - scalastyle helps keep us consistent.

[fthomas]

This should be scalastyle:on null, right?

[fthomas]

Btw, it seems that you can also disable scalastyle on single lines with

var ois: ObjectInputStream = null // scalastyle:ignore null

see http://www.scalastyle.org/configuration.html.

[peterneyens]

Thanks for finding another of my errors. I didn't know you could also specify the checker in the single line comment.

[non]

It seems like a few of these rules (e.g. number.of.types) aren't really doing much for us. Does anyone think we should leave these rules on? I would be just as happy to turn them off as to disable them.

EDIT: I don't think @peterneyens has to necessarily "solve" this for us but since there's an open PR I figured I'd mention it here.

[peterneyens]

@non You are right, I figured it was best to get scalastyle working first and then worry about which rules we might have to change with some input from you guys.

The NumberOfTypes rule seems indeed a prime candidate to be removed from our scalastyle config. I would be happy to remove this and other rules in this PR if that's what we want.

[fthomas]

👍 (when the build is green). Thanks @peterneyens!

I'd prefer merging this sooner than later and changing the scalastyle configuration in subsequent PRs. Is that okay for you, @non?

[ceedubs]

I agree that number of types is a prime candidate for rule removal in a separate PR, but I'm going to go ahead and merge this to get scalastyle rolling again. thanks again @peterneyens!