Skip to content

Conversation

@TomasMikula
Copy link
Contributor

See #616.

@TomasMikula
Copy link
Contributor Author

/cc @ceedubs @adelbertc

@ceedubs
Copy link
Contributor

ceedubs commented May 17, 2016

I don't understand why, but it looks like the build is failing with this:

[error] /home/travis/build/typelevel/cats/core/src/main/scala/cats/MonadRec.scala:5: not found: value FlatMapRec
[error] @typeclass trait MonadRec[F[_]] extends Monad[F] with FlatMapRec[F]
[error]  ^
[error] /home/travis/build/typelevel/cats/core/src/main/scala/cats/MonadRec.scala:5: not found: value FlatMapRec
[error] @typeclass trait MonadRec[F[_]] extends Monad[F] with FlatMapRec[F]
[error]  ^

@codecov-io
Copy link

Current coverage is 88.13%

Merging #1040 into master will decrease coverage by 0.64%

  1. 6 files (not in diff) in ...in/scala/cats/kernel were modified. more
    • Misses +11
    • Hits -11
  2. 1 files (not in diff) in kernel were modified. more
    • Misses +3
    • Hits -3
  3. 2 files (not in diff) in .../main/scala/cats/std were modified. more
  4. 2 files (not in diff) in ...n/scala/cats/functor were modified. more
  5. 3 files (not in diff) in ...main/scala/cats/data were modified. more
  6. 3 files (not in diff) in .../src/main/scala/cats were modified. more
    • Misses +2
    • Hits -2
@@             master      #1040   diff @@
==========================================
  Files           215        217     +2   
  Lines          2727       2729     +2   
  Methods        2663       2667     +4   
  Messages          0          0          
  Branches         59         57     -2   
==========================================
- Hits           2421       2405    -16   
- Misses          306        324    +18   
  Partials          0          0          

Sunburst

Powered by Codecov. Last updated by 22f2000...2ae9d8a

@adelbertc
Copy link
Contributor

So when I (halfway) implemented this many moons ago I tried to write a test that would test the stack safety of implementations.. is that possible?

@TomasMikula
Copy link
Contributor Author

@ceedubs strange, I haven't seen that error. But I fixed a Scaladoc link so now the travis build started again.

@TomasMikula
Copy link
Contributor Author

@adelbertc Yeah, but that should go to #1041 then.

@TomasMikula
Copy link
Contributor Author

2.11.8 test is succeeding now. 2.10.6 failed and I can't even tell why.

@adelbertc
Copy link
Contributor

@TomasMikula is it possible to get this and #1041 put into 1 PR? either this one or that one?

@TomasMikula
Copy link
Contributor Author

@adelbertc sure, #1041 contains the commit of this PR as well.

@adelbertc
Copy link
Contributor

Closed in favor of #1041

@adelbertc adelbertc closed this May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants