-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"-MF" is not a special version and so "1.0.0" < "1.0.0-MF" #2131
Comments
Ugh, grim. Releasing |
As an aside, it also means the MF version was "newer" than the RCs. One can imagine ways that could have lessened the exercise received by the RCs (but I really have no idea.) |
@paulp : I think it should have been ok, as the version weren't binary compatible, there is very little chance that anybody used anything but the exact version number. A chance that binary compatibility is not a given! (sorry) |
1.0.1 on the way to maven central. Will announce later
…On Sun, Dec 31, 2017, 02:07 Francois Armand ***@***.***> wrote:
@paulp <https://github.com/paulp> : I think it should have been ok, as
the version weren't binary compatible, there is very little chance that
anybody used anything but the exact version number. A chance that binary
compatibility is not a given! (sorry)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2131 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFFOcr-KqjNBfaJOj3Ji19wri_pSG6tks5tFzKwgaJpZM4RPx-N>
.
|
Now that 1.0.1 is published, that issue can be closed. I'm not sure about cats level process, who should do it? |
Works around irritating Maven ordering of 1.0.0-MF. typelevel/cats#2131
Works around irritating Maven ordering of 1.0.0-MF. typelevel/cats#2131
In maven ordering, a shorthand milestone identifier ("m") must be followed by a number to be considered as such, else the segment is not special. See https://github.com/apache/maven/blob/master/maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java#L176 (only spec I know of for maven version rules).
So it means that
cats-core_2.12-1.0.0
is considered to be beforecats-core_2.12-1.0.0-MF
, which is not good at all: nobody will ever be able to use[1.0.0,1.1)
(or any qualifier meaning '1.0 or above, binary compatible version).See for example in maven central:
1.0.0-MF
is not red1.0.0-MF
.Artifacts being published (and can't be unpublished in an open world), that horse left a long time ago, so I'm not sure what is the correct way forward.
Perhaps the best option is to have a
1.0.1
release quickly, which would assure that the versionning of the whole ecosystem is correct regarding the1.0
branch, which aims to be stable.The text was updated successfully, but these errors were encountered: