Merge pull request #1127 from johnynek/oscar/tryharder

Add Xor.toTry
typelevel · Jun 15, 2016 · ae309c1 · ae309c1
2 parents 3c8f03c + 2eebf31
commit ae309c1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/core/src/main/scala/cats/data/Xor.scala b/core/src/main/scala/cats/data/Xor.scala
@@ -69,6 +69,8 @@ sealed abstract class Xor[+A, +B] extends Product with Serializable {
 
   def toList: List[B] = fold(_ => Nil, _ :: Nil)
 
+  def toTry(implicit ev: A <:< Throwable): Try[B] = fold(a => Failure(ev(a)), Success(_))
+
   def toValidated: Validated[A,B] = fold(Validated.Invalid.apply, Validated.Valid.apply)
 
   /** Returns a [[ValidatedNel]] representation of this disjunction with the `Left` value

diff --git a/tests/src/test/scala/cats/tests/XorTests.scala b/tests/src/test/scala/cats/tests/XorTests.scala
@@ -204,6 +204,14 @@ class XorTests extends CatsSuite {
     }
   }
 
+  test("toTry then fromTry is identity") {
+    implicit def eqTh: Eq[Throwable] = Eq.allEqual
+
+    forAll { (x: Throwable Xor String) =>
+      Xor.fromTry(x.toTry) should === (x)
+    }
+  }
+
   test("isLeft consistency") {
     forAll { (x: Int Xor String) =>
       x.isLeft should === (x.toEither.isLeft)