Bracket instance for Kleisli #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
==========================================
+ Coverage 87.81% 88.11% +0.29%
==========================================
Files 60 60
Lines 1494 1498 +4
Branches 148 150 +2
==========================================
+ Hits 1312 1320 +8
+ Misses 182 178 -4 |
|
Looks good. Question: if you don't override all of those methods in |
johnynek
approved these changes
May 20, 2018
|
@alexandru It seems to. (Maybe because of typelevel/cats/pull/2185?) |
|
That's good. Just asking as we need to be aware in case we break coherence. |
alexandru
approved these changes
May 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first step towards fixing #216: adds a
Bracketinstance forKleisli.