Disable monkeypatches, add dependencies via new hook #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 28, 2019
mkurnikov
force-pushed
the
add-deps-using-new-hook
branch
from
af4b507 to
4dd2e42
Compare
Contributor
|
Mypy 0.700 is out, I guess it can be merged now? |
Member
Author
|
@syastrov Tests are faster now, so I split Hope it won't discourage you from contributing. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/mkurnikov/django-stubs/issues/48.
python/mypy#6598
I tried locally, PR indeed solves the issue, all tests (except one) pass.
https://github.com/mkurnikov/django-stubs/blob/master/test-data/typecheck/settings.test#L44