make code in contrib/admin/filters.pyi properly use generics #2908
+33
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
UnknownPlatypus
left a comment
UnknownPlatypus
left a comment
There was a problem hiding this comment.
A few open questions
Comment on lines
+24
to
+26
| _ModelT = TypeVar("_ModelT", bound=Model) | ||
| _ST = TypeVar("_ST", contravariant=True) | ||
| _GT = TypeVar("_GT", covariant=True) |
Contributor
There was a problem hiding this comment.
Can we / should we share these typevar definition with the other places with matching ones ?
Author
There was a problem hiding this comment.
No preference, I have not seen anyone doing it tho
| used_parameters: dict[str, bool | datetime | str] | ||
| def __init__( | ||
| self, request: HttpRequest, params: dict[str, str], model: type[Model], model_admin: ModelAdmin | ||
| self, request: HttpRequest, params: dict[str, str], model: type[Model], model_admin: ModelAdmin[_ModelT] |
Contributor
There was a problem hiding this comment.
Should model also be modelT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
I improved usage of generics in
contrib/admin/filters.pyiRelated issues
I haven't been able to find any.