Repository navigation
Improve loader CLI ergonomics - #365
Open
flyingsilverfin wants to merge 1 commit into
Open
flyingsilverfin wants to merge 1 commit into
flyingsilverfin wants to merge 1 commit into
Conversation
Reformat multi-option error messages (checkpoint exists, --batch-rows resume conflict, in-flight batch prompt) as indented solution lists, warn when --create-db creates a database without a --schema-file, and override the clap usage line with one synopsis per invocation mode (fresh load vs --resume). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
flyingsilverfin
commented
Jul 30, 2026
|
|
||
| pub const USERNAME_VALUE_NAME: &str = "username"; | ||
|
|
||
| /// The two invocation modes: a fresh load (connection, database, query, and data are required), |
Member
Author
There was a problem hiding this comment.
@sam-butcher this is gonna be deleted but i can't on the plane cuz my ssh connection gets blocked lol
sam-butcher
reviewed
Jul 31, 2026
sam-butcher
left a comment
sam-butcher
left a comment
Member
There was a problem hiding this comment.
While we're addressing the --create-db without --schema-file question, is it worth making that an error up-front actually? I can't really think of any use case where passing --create-db without --schema-file will do anything other than error later on anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage and product changes
Implementation
Update error messages and help menu