Skip to content

Introduce computed values #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 26, 2023

Conversation

flyingsilverfin
Copy link
Member

What is the goal of this PR?

We allow users to interact via Console with the new Value API introduced in typedb/typeql#260. This PR adds pretty printing for value concepts and updates required dependencies to support the change.

What are the changes implemented in this PR?

  • Update to a client-java version that supports Values in queries and answers
  • Update the concept pretty-printer to allow printing Value concepts.
  • Update ConceptMap printing to first print concept variables ($) by alphabetical sorting of the variable name, and then value variables (?) by alphabetical sorting.

@typedb-bot
Copy link
Member

typedb-bot commented May 25, 2023

PR Review Checklist

Do not edit the content of this comment. The PR reviewer should simply update this comment by ticking each review item below, as they get completed.


Trivial Change

  • This change is trivial and does not require a code or architecture review.

Code

  • Packages, classes, and methods have a single domain of responsibility.
  • Packages, classes, and methods are grouped into cohesive and consistent domain model.
  • The code is canonical and the minimum required to achieve the goal.
  • Modules, libraries, and APIs are easy to use, robust (foolproof and not errorprone), and tested.
  • Logic and naming has clear narrative that communicates the accurate intent and responsibility of each module (e.g. method, class, etc.).
  • The code is algorithmically efficient and scalable for the whole application.

Architecture

  • Any required refactoring is completed, and the architecture does not introduce technical debt incidentally.
  • Any required build and release automations are updated and/or implemented.
  • Any new components follows a consistent style with respect to the pre-existing codebase.
  • The architecture intuitively reflects the application domain, and is easy to understand.
  • The architecture has a well-defined hierarchy of encapsulated components.
  • The architecture is extensible and scalable.

@typedb-bot typedb-bot requested review from alexjpwalker and removed request for alexjpwalker May 25, 2023 13:14
@typedb-bot typedb-bot requested review from alexjpwalker and removed request for alexjpwalker May 25, 2023 13:14
@typedb-bot typedb-bot requested review from alexjpwalker and removed request for alexjpwalker May 25, 2023 13:14
@typedb-bot typedb-bot requested a review from alexjpwalker May 25, 2023 13:14
@flyingsilverfin flyingsilverfin changed the title Introduce values Introduce computed values May 25, 2023
@flyingsilverfin flyingsilverfin merged commit 26a8244 into typedb:master May 26, 2023
@flyingsilverfin flyingsilverfin deleted the introduce-values branch May 26, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants