Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes & updates #2

Merged
merged 12 commits into from
Sep 10, 2016
Merged

Fixes & updates #2

merged 12 commits into from
Sep 10, 2016

Conversation

IOAyman
Copy link
Collaborator

@IOAyman IOAyman commented Sep 10, 2016

  • Fixed isAfter and isBefore: The 2nd arg should be a string
  • Updated documentation for isMobilePhone
  • Upgraded typings tool
  • Update the API to the latest version v5.6.0:
    • Added isDataURI, isMD5 validators and unescape sanitizer
  • removed toString

@blakeembrey
Copy link
Member

LGTM /cc @louy. Would you be interested in helping maintain the project? I can add you as a collaborator if you are 😄

@IOAyman
Copy link
Collaborator Author

IOAyman commented Sep 10, 2016

@blakeembrey, I'd be glad to 😄

@blakeembrey
Copy link
Member

blakeembrey commented Sep 10, 2016

@IOAyman Great! I've added you, just try to stick to PRs still so anyone else can jump in 😄

Edit: Also, use squashing 😄

@blakeembrey blakeembrey merged commit ceb106d into typed-typings:master Sep 10, 2016
@blakeembrey
Copy link
Member

@IOAyman There's also the version in https://github.com/types/npm-validator/blob/master/typings.json which will usually need updating. I created some basic guidelines in https://github.com/types/guidelines, not sure how useful that is for you.

@blakeembrey blakeembrey mentioned this pull request Sep 10, 2016
@IOAyman
Copy link
Collaborator Author

IOAyman commented Sep 10, 2016

@blakeembrey, Thnaks! I'll update the remaining file, and squash things 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants