Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support TS 2.9 #399

Merged
merged 5 commits into from
Jul 14, 2018
Merged

feat: support TS 2.9 #399

merged 5 commits into from
Jul 14, 2018

Conversation

ikatyang
Copy link
Member

Fixes #391

@ikatyang ikatyang requested a review from KiaraGrouwstra July 10, 2018 06:38
@ikatyang ikatyang mentioned this pull request Jul 10, 2018
Closed
KiaraGrouwstra
KiaraGrouwstra approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@KiaraGrouwstra KiaraGrouwstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, congrats on pulling off the upgrade! :)

@ikatyang ikatyang merged commit ffabbd5 into master Jul 14, 2018
@ikatyang ikatyang deleted the feat/ts-2.9 branch July 14, 2018 07:10
@vilanz
Copy link

vilanz commented Jul 17, 2018

@ikatyang Does it break Typescript 2.7 compatibility?

@ikatyang
Copy link
Member Author

This PR uses conditional types which is available since TS 2.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiaraGrouwstra KiaraGrouwstra KiaraGrouwstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikatyang @vilanz @KiaraGrouwstra