Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(equals): add void cases #384

Merged
merged 3 commits into from
Mar 2, 2018
Merged

feat(equals): add void cases #384

merged 3 commits into from
Mar 2, 2018

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Mar 1, 2018

Fixes #383

@ikatyang ikatyang requested a review from KiaraGrouwstra March 1, 2018 07:04
KiaraGrouwstra
KiaraGrouwstra approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@KiaraGrouwstra KiaraGrouwstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, (T, T) is admittedly unreasonably strict in general.

@ikatyang ikatyang merged commit 5683f58 into master Mar 2, 2018
@ikatyang ikatyang deleted the feat/equals-void branch March 2, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KiaraGrouwstra KiaraGrouwstra KiaraGrouwstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikatyang @KiaraGrouwstra