Node acceptance tests, round 2 #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfreeman
force-pushed
the
node-acceptance-tests
branch
2 times, most recently
from
6e425c4 to
84cbb10
Compare
dfreeman
force-pushed
the
node-acceptance-tests
branch
from
10ea433 to
63e85b7
Compare
dfreeman
force-pushed
the
node-acceptance-tests
branch
from
65e8f29 to
9f00685
Compare
This was referenced May 21, 2018
Merged
dfreeman
force-pushed
the
node-acceptance-tests
branch
from
50a1454 to
c8607d2
Compare
dfreeman
pushed a commit
that referenced
this pull request
Aug 21, 2018
Node acceptance tests, round 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an alternative approach to what @csantero started in #173. Rather than using
ember-cli-addon-tests, it sets up a barebones "skeleton app" that we can interact with in acceptance tests.Vitally, this app inherits its dependencies from the host addon rather than running through the whole process of installing its own. This speeds things up significantly and avoids the
npm installstep that can be a common point of failure in CI with ec-addon-tests. Very little of what's inskeleton-appand the corresponding fixture directory is actually unique to our needs in ember-cli-typescript, so we could consider factoring it out into a standalone library at some point in the future if it seems independently useful.The bug fixed in #214 was originally caught by the tests on this branch, and the work I've been doing on type generation also makes use of the skeleton app helper.