Skip to content

[RFC] What constitutes a breaking change? #249

Closed
@mike-north

Description

@mike-north

Because of #246 / DefinitelyTyped/DefinitelyTyped#28282 we've hit a point where we have to think about how SemVer, library version and the Ember/TS version support policy interact.

TL;DR - a feature was added to TS 3.1 nightly builds which caused @types/ember to break. TypeScript regards their change as non-breaking, and thus appropriate for a minor release.

However -- to get things working in @types/ember, we've had to use TypeScript 2.8 features. In a sense, we've definitely broken things for someone who's using TypeScript 2.4. There are a variety of packages that depend on @types/ember that will need to be bumped up before we can merge in the fix

I believe some options to discuss are

(1) Bump everything up, and encourage everyone to start using TypeScript 2.8 (this is what the PR currently does)
(2) Take the current types, put them in a /v2 folder, and alter all the dependencies such that they point to /v2. After nothing depends on the v2 types, merge in the fix as the first commit of a v3 release series

Metadata

Metadata

Assignees

No one assigned

    Labels

    RFCRequests for Comments

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions