EC2 SD: Validate HTTP config

Related-to prometheus#12810 Signed-off-by: Jayapriya Pai <janantha@redhat.com>
tylitianrui · Sep 8, 2023 · 7f085ae · 7f085ae
1 parent 7a87d0d
commit 7f085ae
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/config/config_test.go b/config/config_test.go
@@ -1745,6 +1745,10 @@ var expectedErrors = []struct {
 		filename: "ec2_filters_empty_values.bad.yml",
 		errMsg:   `EC2 SD configuration filter values cannot be empty`,
 	},
+	{
+		filename: "ec2_token_file.bad.yml",
+		errMsg:   `at most one of bearer_token & bearer_token_file must be configured`,
+	},
 	{
 		filename: "section_key_dup.bad.yml",
 		errMsg:   "field scrape_configs already set in type config.plain",

diff --git a/config/testdata/ec2_token_file.bad.yml b/config/testdata/ec2_token_file.bad.yml
@@ -0,0 +1,6 @@
+scrape_configs:
+  - job_name: foo
+    ec2_sd_configs:
+      - region: us-east-1
+        bearer_token: foo
+        bearer_token_file: foo
diff --git a/discovery/aws/ec2.go b/discovery/aws/ec2.go
@@ -129,7 +129,7 @@ func (c *EC2SDConfig) UnmarshalYAML(unmarshal func(interface{}) error) error {
 			return errors.New("EC2 SD configuration filter values cannot be empty")
 		}
 	}
-	return nil
+	return c.HTTPClientConfig.Validate()
 }
 
 // EC2Discovery periodically performs EC2-SD requests. It implements