Package resource type

[pulquero]

Refactored to create a 'package' resource type so it is possible to install multiple jdk versions.

Example:
jdk_oracle::package {
'jdk6':
version => '6',
create_symlink => false,
default_java => false;
'jdk7':
version => '7'
}

Changes:
contents of init.pp moved to package.pp and resource titles made unique by addition of _${version} where necessary.

[tylerwalts]

Thanks, generally this is a great idea, especially for use cases like configuring a CI build server. There is another fork out there that just converted it from a class to a define in the main init.pp, but no PR was done:

https://github.com/burdara/puppet-jdk_oracle/blob/master/manifests/init.pp

A few feedback items:

• For the naming, I feel like package.pp is somewhat misleading since we are installing intentionally from tarball vs using a OS package.
  • Could we call it something more generic, like install.pp?
• Tests are not passing
  • Not sure right now if it was caused by your commits or some other issue?

[tylerwalts]

Should this now be: jdk_oracle::install ?

[pulquero]

Yes.

[tylerwalts]

This seems like a breaking change and people may have to update their references to use it as a define now vs a class (exa: hiera users), so it feels like this should be a major 2.0.0 release, to make it clear that change will happen. Agree/disagree?

[pulquero]

I disagree, the original class definition is still there, so anybody still using it should not be affected. But, I'm not a puppet expert, so don't know if I'm overlooking something.

[tylerwalts]

Good point, we have the original class with parameters which remain unchanged, so it would be the implementer's option to call the define directly, or not.

[coveralls]

Changes Unknown when pulling 94768a5 on pulquero:package-resource-type into ** on tylerwalts:master**.