Revive to replace golint

Brewfile

@@ -0,0 +1,3 @@
+brew "pkg-config"
+brew "gpgme"
+brew "gnupg"

README.md

@@ -43,6 +43,8 @@ The suggested way to start running crie is to run `chk` at the top of your proje
     crie chk --continue
 ```
 
+💡 Have ideas or ran into a bug? Open an issue — I’d love your feedback!
+
 ## Documentation
 
 See the **[documentation](doc/README.md)** for installation, configuration, and usage guides.

cmd/crie/main.go

@@ -1,3 +1,4 @@
+// Package main is the main entrypoint for the crie CLI.
 package main
 
 import (

cmd/docgen/main.go

@@ -1,3 +1,4 @@
+// Package main generates CLI reference documentation for crie.
 package main
 
 import (

img/apk/Dockerfile

@@ -15,6 +15,12 @@
 COPY --from=clang_layer /usr/lib/llvm20/lib/libclang-cpp.so.20.1 /usr/lib/llvm20/lib/libclang-cpp.so.20.1
 COPY --from=clang_layer /usr/lib/llvm20/lib/libLLVM.so.20.1 /usr/lib/llvm20/lib/libLLVM.so.20.1
 COPY --from=clang_layer /usr/bin/clang-format /bin/clang-format
-RUN apk --no-cache add cppcheck asciidoctor
+RUN apk --no-cache add cppcheck asciidoctor vale
+
+ENV VALE_CONFIG_PATH=/etc/vale/.vale.ini
+COPY --chmod=644 conf/markdown/.vale.ini $VALE_CONFIG_PATH
+RUN chmod -R 755 /etc/vale
+# hadolint ignore=DL3059
+RUN vale sync
 
 USER standards

img/apk/conf/markdown/.vale.ini

@@ -0,0 +1,10 @@
+StylesPath = styles
+
+MinAlertLevel = suggestion
+
+Packages = write-good, proselint
+
+# Global settings (applied to every syntax)
+[*]
+# List of styles to load
+BasedOnStyles = proselint, write-good

img/docker-compose.yml

@@ -1,13 +1,17 @@
 services:
+  # apk tools - preferred
   apk:
     image: docker.io/tyhal/crie-dep-apk
     build: apk
+  # go native tools - TODO shouldn't be needed
   go:
     image: docker.io/tyhal/crie-dep-go
     build: go
+  # js tools
   npm:
     image: docker.io/tyhal/crie-dep-npm
     build: npm
+  # python tools
   pip:
     image: docker.io/tyhal/crie-dep-pip
     build: pip

img/go/Dockerfile

@@ -7,7 +7,6 @@ FROM go_layer AS golint_layer
 # hadolint ignore=DL3062
 RUN go install github.com/errata-ai/vale@latest \
     && go install github.com/mgechev/revive@latest \
-    && go install golang.org/x/lint/golint@latest \
     && go install github.com/yoheimuta/protolint/cmd/protolint@latest
 
 
@@ -18,7 +17,6 @@ RUN adduser -D standards
 # [ Golang ]
 COPY --from=go_layer /usr/local/go/bin/gofmt /bin/gofmt
 COPY --from=golint_layer /go/bin/revive /bin/revive
-COPY --from=golint_layer /go/bin/golint /bin/golint
 COPY --from=golint_layer /go/bin/vale /bin/vale
 COPY --from=golint_layer /go/bin/protolint /bin/protolint
 

img/pip/Dockerfile

@@ -16,7 +16,9 @@ RUN mkdir /.ansible \
 RUN adduser -D standards
 USER standards
 
-ENV YAMLLINT_CONFIG_FILE=/home/standards/.config/yamllint/config
+ENV XDG_CONFIG_DIR=/etc/.config
+
+ENV YAMLLINT_CONFIG_FILE=$XDG_CONFIG_DIR/yamllint/config
 COPY --chown=standards:standards conf/yaml/.yamllint.yaml $YAMLLINT_CONFIG_FILE
-ENV CMAKELINT_CONFIG_FILE=/home/standards/.config/cmakelintrc
+ENV CMAKELINT_CONFIG_FILE=$XDG_CONFIG_DIR/cmakelintrc
 COPY --chown=standards:standards conf/cmake/.cmakelintrc $CMAKELINT_CONFIG_FILE

internal/cli/complete.go

@@ -38,7 +38,7 @@ func completeGitTarget(_ *cobra.Command, _ []string, _ string) ([]cobra.Completi
 }
 
 func completeLanguage(cmd *cobra.Command, _ []string, toComplete string) ([]cobra.Completion, cobra.ShellCompDirective) {
-	filter := func(l language.Language) bool { return true }
+	filter := func(_ language.Language) bool { return true }
 	switch cmd.Name() {
 	case "fmt":
 		filter = func(l language.Language) bool {

internal/cli/details.go

@@ -22,7 +22,7 @@ var LsCmd = &cobra.Command{
 	Long:              `Show all languages available and the commands run when used`,
 	Args:              cobra.NoArgs,
 	ValidArgsFunction: cobra.FixedCompletions(nil, cobra.ShellCompDirectiveNoFileComp),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		err := crieRun.Languages.Show(os.Stdout)
 		if err != nil {
 			log.Fatal(errchain.From(err).Link("crie list failed"))
@@ -40,7 +40,7 @@ var NonCmd = &cobra.Command{
 Find the file extensions that dont have an associated regex match within crie`,
 	Args:              cobra.NoArgs,
 	ValidArgsFunction: cobra.FixedCompletions(nil, cobra.ShellCompDirectiveNoFileComp),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		err := crieRun.NoStandards()
 		if err != nil {
 			log.Fatal(errchain.From(err).Link("finding unassociated files"))

internal/cli/lint.go

@@ -73,7 +73,7 @@ var ChkCmd = &cobra.Command{
 	Long:              `Check all code standards for coding conventions`,
 	Args:              cobra.NoArgs,
 	ValidArgsFunction: cobra.FixedCompletions(nil, cobra.ShellCompDirectiveNoFileComp),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		err := crieRun.Run(runner.LintTypeChk)
 
 		if err != nil {
@@ -89,7 +89,7 @@ var FmtCmd = &cobra.Command{
 	Long:              `Run all formatters in the list`,
 	Args:              cobra.NoArgs,
 	ValidArgsFunction: cobra.FixedCompletions(nil, cobra.ShellCompDirectiveNoFileComp),
-	Run: func(cmd *cobra.Command, args []string) {
+	Run: func(_ *cobra.Command, _ []string) {
 		err := crieRun.Run(runner.LintTypeFmt)
 
 		if err != nil {

internal/cli/root.go

@@ -40,7 +40,7 @@ format all python files
 	Long: `
 	crie brings together a vast collection of formatters and linters
 	to create a handy tool that can sanity check any codebase.`,
-	PersistentPreRunE: func(cmd *cobra.Command, args []string) error {
+	PersistentPreRunE: func(_ *cobra.Command, _ []string) error {
 
 		viper.SetConfigFile(projectConfigPath)
 		viper.SetConfigType("yml")

internal/config/language/config.go

@@ -1,3 +1,4 @@
+// Package language contains configuration structures and helpers for language definitions.
 package language
 
 import (

internal/config/language/defaults.yml

@@ -114,8 +114,8 @@ languages:
     chk:
       type: cli
       exec:
-        bin: golint
-        start: ["-set_exit_status"]
+        bin: revive
+        start: ["-config", "/etc/revive/revive.toml", "-set_exit_status"]
       img: "ghcr.io/tyhal/crie-dep-go"
       tag_crie_version: true
   markdown:
@@ -132,7 +132,6 @@ languages:
       type: cli
       exec:
         bin: vale
-        start: ["--config=/etc/vale/.vale.ini"]
       img: "ghcr.io/tyhal/crie-dep-go"
       tag_crie_version: true
   asciidoctor:
@@ -141,7 +140,6 @@ languages:
       type: cli
       exec:
         bin: vale
-        start: ["--config=/etc/vale/.vale.ini"]
       img: "ghcr.io/tyhal/crie-dep-go"
       tag_crie_version: true
   json:
@@ -207,6 +205,6 @@ languages:
       type: cli
       exec:
         bin: cmakelint
-        start: ["--config=/home/standards/.config/cmakelintrc"]
+        start: ["--config=/etc/.config/cmakelintrc"]
       img: "ghcr.io/tyhal/crie-dep-pip"
       tag_crie_version: true

internal/config/project/schema_test.go

@@ -4,6 +4,6 @@ import (
 	"testing"
 )
 
-func TestProjectSchema(t *testing.T) {
+func TestProjectSchema(_ *testing.T) {
 	Schema()
 }

internal/filelist/dir.go

@@ -1,3 +1,4 @@
+// Package filelist provides utilities to build file lists from directories.
 package filelist
 
 import (
@@ -11,7 +12,7 @@ func FromDir(dir string) ([]string, error) {
 	var files []string
 
 	// Create an initial file list
-	err := filepath.Walk(dir, func(currPath string, f os.FileInfo, err error) error {
+	err := filepath.Walk(dir, func(currPath string, f os.FileInfo, _ error) error {
 		if !f.IsDir() {
 			relPath, err := filepath.Rel(dir, currPath)
 			if err != nil {

internal/runner/execution.go

@@ -1,3 +1,4 @@
+// Package runner contains the logic to run the linters
 package runner
 
 import (

internal/runner/filter_test.go

@@ -24,7 +24,7 @@ func TestFilter(t *testing.T) {
 	}
 
 	// Test empty result
-	result = Filter([]string{}, true, func(s string) bool { return true })
+	result = Filter([]string{}, true, func(_ string) bool { return true })
 	if len(result) != 0 {
 		t.Errorf("expected empty slice, got %v", result)
 	}

internal/runner/language.go

@@ -1,3 +1,4 @@
+// Package runner contains the logic to run the linters
 package runner
 
 import (

pkg/linter/cli/cli.go

@@ -1,3 +1,4 @@
+// Package cli allows a CLI tool to be linted from the host or in a container
 package cli
 
 import (

pkg/linter/cli/exec/exec.go

@@ -1,3 +1,4 @@
+// Package exec allows for a CLI tool to be executed in different contexts
 package exec
 
 import "io"

pkg/linter/dockfmt/dockfmt_test.go

@@ -22,7 +22,7 @@ func TestLint_WillRun(t *testing.T) {
 	assert.NoError(t, l.WillRun())
 }
 
-func TestLint_Cleanup(t *testing.T) {
+func TestLint_Cleanup(_ *testing.T) {
 	l := &LintDockFmt{}
 	var wg sync.WaitGroup
 	wg.Add(1)

pkg/linter/noop/noop_test.go

@@ -21,7 +21,7 @@ func TestLint_WillRun(t *testing.T) {
 	assert.NoError(t, l.WillRun())
 }
 
-func TestLint_Cleanup(t *testing.T) {
+func TestLint_Cleanup(_ *testing.T) {
 	l := &LintNoop{}
 	var wg sync.WaitGroup
 	wg.Add(1)

pkg/linter/reporter.go

@@ -54,7 +54,7 @@ func (r *Runner) Log(rep *Report) error {
 		} else {
 			r.logConditional(strings.NewReader(rep.Err.Error()), "toolerr", log.ErrorLevel)
 		}
-		if id != "" {
+		if !r.StrictLogging {
 			_ = r.folder.Stop(id)
 		}
 	}

pkg/linter/shfmt/file.go

@@ -15,7 +15,7 @@ import (
 	"mvdan.cc/sh/v3/syntax"
 )
 
-func (s *shfmt) formatPath(path string, checkShebang bool) error {
+func (s *shfmt) formatPath(path string, _ bool) error {
 	var readBuf bytes.Buffer
 	var copyBuf = make([]byte, 32*1024)
 

pkg/linter/shfmt/shfmt_test.go

@@ -24,7 +24,7 @@ func TestLint_WillRun(t *testing.T) {
 	assert.NoError(t, l.WillRun())
 }
 
-func TestLint_Cleanup(t *testing.T) {
+func TestLint_Cleanup(_ *testing.T) {
 	l := &LintShfmt{}
 	var wg sync.WaitGroup
 	wg.Add(1)

script/bootstrap

@@ -1,12 +1,14 @@
 #!/bin/sh
 set -xe
 
+cd "$(dirname "$0")/.."
+
 has_command() {
 	command -v "$1" >/dev/null 2>&1
 }
 
 install_brew() {
-	xargs brew install <"$(dirname "$0")/pkgs/brew.txt"
+	brew bundle
 }
 
 install_apt() {

verify/lang/go/src/gol.go

@@ -1,3 +1,4 @@
+// Package main is a dummy package for testing
 package main
 
 import "fmt"