refactor: Eliminating roundtrip-codec safe structures #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test but the failing ones
sterraf
commented
Feb 28, 2025
sterraf
commented
Feb 28, 2025
sterraf
commented
Feb 28, 2025
sterraf
commented
Feb 28, 2025
sterraf
commented
Feb 28, 2025
| } else { | ||
| None | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This is a bit verbose, I'll try a slicker form afterwards (same repeated two times below in the same file)
Contributor
Author
|
@scarmuega There are some comments on the more nuanced decisions above. Please tell me if this is the right direction in order to keep up with the updated |
`validate` not building yet.
scarmuega
reviewed
Mar 13, 2025
| &mut mk_alonzo_vk_wits_check_list(&tx_wits.vkeywitness, ShelleyMA(MissingVKWitness))?; | ||
| let tx_hash: &Vec<u8> = &Vec::from(tx_body.compute_hash().as_ref()); | ||
| let tx_hash: &Vec<u8> = &Vec::from(tx_body.original_hash().as_ref()); | ||
| println!("Tx hash: {:02x?}", tx_hash.clone()); |
Contributor
Author
There was a problem hiding this comment.
The second line is not needed, thanks. It was there for debugging.
scarmuega
reviewed
Mar 18, 2025
Comment on lines
581
to
587
| if let Some(last_slot) = last_slot { | ||
| assert!(last_slot < block.slot()); | ||
| // Taking care of Byron era up to the switch to protocol v.1.0 | ||
| if last_slot <= 3780000 && last_slot % 21600 == 0 { | ||
| assert!(last_slot <= block.slot()); | ||
| } else { | ||
| assert!(last_slot < block.slot()); | ||
| } |
Member
There was a problem hiding this comment.
Instead of relying on fixed slot boundaries, inspect the block and only apply the more relaxed check on EBBs.
scarmuega
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP addressing #605. Some notes:
PositiveCoinwas not eliminated yet;CborWrapis still unrevised;NonEmpty)SetandOrderPreservingPropertiesrequire further discussion.The changes were propagated through the whole library.