Compatibility update for PyTorch API v1.0 #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…input 2. changed parameter name "async" to "non_blocking". Start from Python 3.5, "async" has become a keyword and torch has changed the parameter name.
Signed-off-by: Bill Tao <billtao@pku.edu.cn>
…seem to be a list. Signed-off-by: Bill Tao <billtao@pku.edu.cn>
Signed-off-by: Bill Tao <billtao@pku.edu.cn>
Repaired deprecated call to APIs, the program now exhibits no warning except malformed input data. Signed-off-by: Bill Tao <billtao@pku.edu.cn>
txie-93
requested changes
May 4, 2019
Closed
Signed-off-by: Bill Tao <billtao@pku.edu.cn>
Signed-off-by: Bill Tao <billtao@pku.edu.cn>
txie-93
approved these changes
May 5, 2019
|
One more comment: could you update the README file to show that the code currently works for the latest version of the PyTorch? |
|
You mean to update the dependencies section, to set the pytorch version to the latest? |
|
Correct. Can you remove all the sentences that indicates the code only works up to v0.4? |
Signed-off-by: Bill Tao <billtao@pku.edu.cn>
|
Updated. |
|
Excellent! Thanks for all the updates. |
txie-93
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.