Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint warning in GeoJSON unmarshaling #249

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

kbolino
Copy link
Contributor

@kbolino kbolino commented Jul 29, 2024

A double pointer is needed here to pass through null as nil.

Note that the tests still pass after this change.

A double pointer is needed here to pass through null as nil.
@kbolino kbolino changed the title Fix lint warning Fix lint warning in GeoJSON unmarshaling Jul 29, 2024
@twpayne
Copy link
Owner

twpayne commented Jul 29, 2024

Great catch thanks! The darwin failure is unrelated to this PR.

@twpayne twpayne merged commit eb57e62 into twpayne:master Jul 29, 2024
3 of 4 checks passed
@twpayne
Copy link
Owner

twpayne commented Jul 29, 2024

I've pushed tag v1.5.5 which includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants