Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added passive event listeners support #94

Merged
merged 1 commit into from
May 20, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
added passive event listeners support
  • Loading branch information
Martin Chaov committed May 19, 2017
commit 2b90e505c12ecafbe61f8e58ba2eb03f64fc1df8
36 changes: 27 additions & 9 deletions src/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,22 @@ const LISTEN_FLAG = 'data-lazyload-listened';
const listeners = [];
let pending = [];

// try to handle passive events
let passiveEventSupported = false;
try {
let opts = Object.defineProperty({}, 'passive', {
get: function () {
passiveEventSupported = true;
}
});
window.addEventListener("test", null, opts);
}
catch (e) { }
// if they are supported, setup the optional params
// IMPORTANT: FALSE doubles as the default CAPTURE value!
const passiveEvent = passiveEventSupported ? { capture: false, passive: true } : false;


/**
* Check if `component` is visible in overflow container `parent`
* @param {node} component React component
Expand Down Expand Up @@ -192,12 +208,12 @@ class LazyLoad extends Component {
}

if (needResetFinalLazyLoadHandler) {
off(window, 'scroll', finalLazyLoadHandler);
off(window, 'resize', finalLazyLoadHandler);
off(window, 'scroll', finalLazyLoadHandler, passiveEvent);
off(window, 'resize', finalLazyLoadHandler, passiveEvent);
finalLazyLoadHandler = null;
}

if (!finalLazyLoadHandler) {
if (!finalLazyLoadHandler && passiveEvent === false) {
if (this.props.debounce !== undefined) {
finalLazyLoadHandler = debounce(lazyLoadHandler, typeof this.props.debounce === 'number' ?
this.props.debounce :
Expand All @@ -209,26 +225,28 @@ class LazyLoad extends Component {
300);
delayType = 'throttle';
}
} else {
finalLazyLoadHandler = lazyLoadHandler;
}

if (this.props.overflow) {
const parent = scrollParent(ReactDom.findDOMNode(this));
if (parent && typeof parent.getAttribute === 'function') {
const listenerCount = 1 + (+parent.getAttribute(LISTEN_FLAG));
if (listenerCount === 1) {
parent.addEventListener('scroll', finalLazyLoadHandler);
parent.addEventListener('scroll', finalLazyLoadHandler, passiveEvent);
}
parent.setAttribute(LISTEN_FLAG, listenerCount);
}
} else if (listeners.length === 0 || needResetFinalLazyLoadHandler) {
const { scroll, resize } = this.props;

if (scroll) {
on(window, 'scroll', finalLazyLoadHandler);
on(window, 'scroll', finalLazyLoadHandler, passiveEvent);
}

if (resize) {
on(window, 'resize', finalLazyLoadHandler);
on(window, 'resize', finalLazyLoadHandler, passiveEvent);
}
}

Expand All @@ -246,7 +264,7 @@ class LazyLoad extends Component {
if (parent && typeof parent.getAttribute === 'function') {
const listenerCount = (+parent.getAttribute(LISTEN_FLAG)) - 1;
if (listenerCount === 0) {
parent.removeEventListener('scroll', finalLazyLoadHandler);
parent.removeEventListener('scroll', finalLazyLoadHandler, passiveEvent);
parent.removeAttribute(LISTEN_FLAG);
} else {
parent.setAttribute(LISTEN_FLAG, listenerCount);
Expand All @@ -260,8 +278,8 @@ class LazyLoad extends Component {
}

if (listeners.length === 0) {
off(window, 'resize', finalLazyLoadHandler);
off(window, 'scroll', finalLazyLoadHandler);
off(window, 'resize', finalLazyLoadHandler, passiveEvent);
off(window, 'scroll', finalLazyLoadHandler, passiveEvent);
}
}

Expand Down
10 changes: 6 additions & 4 deletions src/utils/event.js
Original file line number Diff line number Diff line change
@@ -1,16 +1,18 @@
export function on(el, eventName, callback) {
export function on(el, eventName, callback, opts) {
opts = opts || false;
if (el.addEventListener) {
el.addEventListener(eventName, callback, false);
el.addEventListener(eventName, callback, opts);
} else if (el.attachEvent) {
el.attachEvent(`on${eventName}`, (e) => {
callback.call(el, e || window.event);
});
}
}

export function off(el, eventName, callback) {
export function off(el, eventName, callback, opts) {
opts = opts || false;
if (el.removeEventListener) {
el.removeEventListener(eventName, callback);
el.removeEventListener(eventName, callback, opts);
} else if (el.detachEvent) {
el.detachEvent(`on${eventName}`, callback);
}
Expand Down